This repository has been archived by the owner on May 7, 2020. It is now read-only.
[Tradfri] Improved connection handling #5631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change continues eclipse-archived#5623 by doing some small additional improvements in order to let the GC do its job. Furthermore, with eclipse-archived#5623 in place, the restart of the transport layer as done in eclipse-archived#3675 turned out to be not needed anymore. Therefore it is reverted in this PR again. This allows the reliability layer to do its job and e.g. re-deliver commands within a certain timeframe in case of a short connection loss. relates to eclipse-archived#5622 Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
kaikreuzer
approved these changes
May 25, 2018
kaikreuzer
changed the title
ermartens
pushed a commit
to ermartens/smarthome
that referenced
this pull request
Jun 15, 2018
This change continues eclipse-archived#5623 by doing some small additional improvements in order to let the GC do its job. Furthermore, with eclipse-archived#5623 in place, the restart of the transport layer as done in eclipse-archived#3675 turned out to be not needed anymore. Therefore it is reverted in this PR again. This allows the reliability layer to do its job and e.g. re-deliver commands within a certain timeframe in case of a short connection loss. relates to eclipse-archived#5622 Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change continues #5623 by doing some small additional
improvements in order to let the GC do its job.
Furthermore, with #5623 in place, the restart of the transport
layer as done in #3675 turned out to be not needed anymore.
Therefore it is reverted in this PR again. This allows the
reliability layer to do its job and e.g. re-deliver commands
within a certain timeframe in case of a short connection loss.
relates to #5622
Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com