This repository has been archived by the owner on May 7, 2020. It is now read-only.
Improved servlet lifecycles for AudioServlet and ChartServlet #6161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/double-chartservlet-in-http-list-charts-error/50919/3 |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
htreu
reviewed
Sep 6, 2018
| @@ -125,9 +124,6 @@ protected void activate() { | |||
| protected void deactivate() { | |||
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/double-chartservlet-in-http-list-charts-error/50919/9 |
htreu
approved these changes
Sep 6, 2018
Signed-off-by: Kai Kreuzer <kai@openhab.org>
clinique
pushed a commit
to clinique/smarthome
that referenced
this pull request
Sep 17, 2018
…e-archived#6161) * Improved servlet lifecycles for AudioServlet and ChartServlet * also adapted DefaultChartProvider * send proper HTTPResponses instead of exceptions * removed empty deactivate method * properly handle NumberFormatExceptions * changed config description to correct types Signed-off-by: Kai Kreuzer <kai@openhab.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Kreuzer kai@openhab.org