added script support for MQTT actions #6660

kaikreuzer · 2018-12-11T11:13:11Z

Signed-off-by: Kai Kreuzer kai@openhab.org

kaikreuzer · 2018-12-11T11:16:29Z

@davidgraeff Took a while as it was more tricky than I thought - but with this change, you can now call the MQTT action from DSL rules like this:

  val actions = getActions("mqtt","mqtt:systemBroker:embedded-mqtt-broker")
  actions.publishMQTT("mytopic","myvalue")

Would be nice if you could briefly test this and provide feedback - as discussed, we should get that into the openHAB 2.4 release.

davidgraeff

Perfect, I will test this tonight. Could you add your example

  val actions = getActions("mqtt","mqtt:systemBroker:embedded-mqtt-broker")
  actions.publishMQTT("mytopic","myvalue")

to the MQTT.generic readme as well?

davidgraeff · 2018-12-11T11:27:25Z

...rthome.binding.mqtt/src/main/java/org/eclipse/smarthome/binding/mqtt/action/MQTTActions.java

@@ -31,11 +31,11 @@
 *
 * @author David Graeff - Initial contribution
 */
-@ActionScope(name = "binding.mqtt")
-@Component(immediate = false, service = { AnnotatedActionThingHandlerService.class })
+@ThingActionsScope(name = "mqtt")


Can you adapt the readme.md file as well? Because that is the only reference documentation at the moment.

kaikreuzer · 2018-12-11T12:53:43Z

@davidgraeff Done!

maggu2810 · 2018-12-12T07:06:51Z

...pse/smarthome/automation/module/script/defaultscope/internal/DefaultScriptScopeProvider.java

@@ -60,6 +67,7 @@
 * @author Simon Merschjohann - refactored to be an ScriptExtensionProvider
 *
 */
+@Component(immediate = true)


We don't need immediate here, do we?
I see it has been immediate before, but as you changed from XML to annotations I think it is a good time to question it.

I agree that it might not be needed, but as this is a last-minute change that I'd like to get into the openHAB 2.4 release, I prefer to keep it the same as before to reduce risk. Happy to remove it in a week!

maggu2810 · 2018-12-12T07:08:12Z

...arthome.model.rule/src/org/eclipse/smarthome/model/rule/jvmmodel/RulesJvmModelInferrer.xtend

@@ -114,7 +114,7 @@ class RulesJvmModelInferrer extends ScriptJvmModelInferrer {
                    logger.warn("Duplicate field: '{}'. Ignoring '{}'.", name, type.class.name)
                }
            ]
-
+            


This change that only adds tailing whitespaces can be removed from the commit.

kaikreuzer · 2018-12-12T08:33:22Z

@davidgraeff Did you have a chance to test?

davidgraeff · 2018-12-12T09:34:46Z

I'm testing now, hold on a moment please

Signed-off-by: Kai Kreuzer <kai@openhab.org>

davidgraeff

Functional testing performed.

It works with the rule DSL under different conditions with two different brokers.

I get:

11:24:56.602 ERROR o.e.s.a.m.c.h.AnnotationActionHandler[:90] - Could not call method 'void org.eclipse.smarthome.binding.mqtt.action.MQTTActions.publishMQTT(java.lang.String,java.lang.String)' from module type 'mqtt.publishMQTT'.
java.lang.IllegalAccessException: Class org.eclipse.smarthome.automation.module.core.handler.AnnotationActionHandler can not access a member of class org.eclipse.smarthome.binding.mqtt.action.MQTTActions with modifiers ""
	at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)
	at java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)
	at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)
	at java.lang.reflect.Method.invoke(Method.java:491)
	at org.eclipse.smarthome.automation.module.core.handler.AnnotationActionHandler.execute(AnnotationActionHandler.java:88)
	at org.eclipse.smarthome.automation.core.internal.RuleEngineImpl.executeActions(RuleEngineImpl.java:1199)
	at org.eclipse.smarthome.automation.core.internal.RuleEngineImpl.runNow(RuleEngineImpl.java:1047)
	at org.eclipse.smarthome.automation.core.internal.RuleEngineImpl.runNow(RuleEngineImpl.java:1063)
	at org.eclipse.smarthome.automation.rest.internal.RuleResource.runNow(RuleResource.java:288)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

When I add a (useless) Paper UI automation rule to fire the MQTT publish action.

kaikreuzer · 2018-12-12T10:31:27Z

When I add a (useless) Paper UI automation rule to fire the MQTT publish action.

This PR is not about making GUI rules work, so this is not in scope. Actually, I think we should remove the registration as an action in the new rule engine as it isn't usable anyhow, would you agree?

davidgraeff · 2018-12-12T10:35:55Z

Oh I just used Paper UI because I have no clue yet how to write automation engine jsons, the result should be similar (except that the mqtt publish is a no-op because no topic is given). So the error is still relevant, isn't it?

I think you don't need to hide it, because the entire module is still marked as experimental. Other UIs (like HaBot) can also create automation rules.

Signed-off-by: Kai Kreuzer <kai@openhab.org>

kaikreuzer · 2018-12-12T12:41:58Z

@davidgraeff With my last commit, I have fixed the IllegalAccessException and it also fixes #6601 on the way.

openhab-bot · 2018-12-12T15:00:25Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mqtt-binding-version-2-4/53811/205

openhab-bot · 2018-12-19T01:27:05Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-2-4-has-been-released/60077/38

davidgraeff reviewed Dec 11, 2018

View reviewed changes

kaikreuzer added the Binding-MQTT label Dec 11, 2018

maggu2810 reviewed Dec 12, 2018

View reviewed changes

kaikreuzer added 3 commits December 12, 2018 11:21

added script support for MQTT actions

8000ffb

Signed-off-by: Kai Kreuzer <kai@openhab.org>

added documentation

b07f4c4

Signed-off-by: Kai Kreuzer <kai@openhab.org>

removed unrelevant change

ac671c0

Signed-off-by: Kai Kreuzer <kai@openhab.org>

kaikreuzer force-pushed the mqttactions branch from 42c5656 to ac671c0 Compare December 12, 2018 10:24

davidgraeff reviewed Dec 12, 2018

View reviewed changes

made module for new rule engine work again

fbe91f9

Signed-off-by: Kai Kreuzer <kai@openhab.org>

htreu merged commit 6b6ee40 into eclipse-archived:master Dec 12, 2018

kaikreuzer deleted the mqttactions branch December 12, 2018 14:50

5iver mentioned this pull request Dec 18, 2018

core.actions is broken after S1465 (possibly in 2.4.0 stable) openhab-scripters/openhab-helper-libraries#56

Closed

5iver mentioned this pull request Dec 19, 2018

[Automation] Rename the newly added actions service to thingActions #6703

Closed

5iver mentioned this pull request Feb 18, 2019

[DSL][automation][WIP] Added methods to retrieve and update thing configurations via rules openhab/openhab-core#583

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added script support for MQTT actions #6660

added script support for MQTT actions #6660

kaikreuzer commented Dec 11, 2018

kaikreuzer commented Dec 11, 2018

davidgraeff left a comment

davidgraeff Dec 11, 2018

kaikreuzer commented Dec 11, 2018

maggu2810 Dec 12, 2018

kaikreuzer Dec 12, 2018

maggu2810 Dec 12, 2018

kaikreuzer Dec 12, 2018

kaikreuzer commented Dec 12, 2018

davidgraeff commented Dec 12, 2018

davidgraeff left a comment •

edited

Loading

kaikreuzer commented Dec 12, 2018

davidgraeff commented Dec 12, 2018 •

edited

Loading

kaikreuzer commented Dec 12, 2018

openhab-bot commented Dec 12, 2018

openhab-bot commented Dec 19, 2018

added script support for MQTT actions #6660

added script support for MQTT actions #6660

Conversation

kaikreuzer commented Dec 11, 2018

kaikreuzer commented Dec 11, 2018

davidgraeff left a comment

Choose a reason for hiding this comment

davidgraeff Dec 11, 2018

Choose a reason for hiding this comment

kaikreuzer commented Dec 11, 2018

maggu2810 Dec 12, 2018

Choose a reason for hiding this comment

kaikreuzer Dec 12, 2018

Choose a reason for hiding this comment

maggu2810 Dec 12, 2018

Choose a reason for hiding this comment

kaikreuzer Dec 12, 2018

Choose a reason for hiding this comment

kaikreuzer commented Dec 12, 2018

davidgraeff commented Dec 12, 2018

davidgraeff left a comment • edited Loading

Choose a reason for hiding this comment

kaikreuzer commented Dec 12, 2018

davidgraeff commented Dec 12, 2018 • edited Loading

kaikreuzer commented Dec 12, 2018

openhab-bot commented Dec 12, 2018

openhab-bot commented Dec 19, 2018

davidgraeff left a comment •

edited

Loading

davidgraeff commented Dec 12, 2018 •

edited

Loading