New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electric Vehicle Model: Internal moment of inertia power calculated incorrectly #12513
Comments
Thank you for looking at this in detail!
|
@namdre wouldn't that be part of |
I assume that it is part of P = F v = T/r_wheel v = (α I)/r_wheel v = (a I)/r_wheel² v |
The publication (Open access version) from the developers of the MMPEVEM model does report their model parameter of 12.5 kg·m², and they seem to verify their results using a dynamometer. So maybe the SUMO default could be changed to that. In addition, the default SUMO EV model needs to have its inertia divided by r_wheel² in HelpersEnergy.cpp#L65. I think if these two changes are implemented, the default model would output a more accurate result, which would correspond with that of the MMPEVEM model... I wonder if @kevbad (co-author of MMPEVEM) has any insights on this...? |
@kevbad This could also be one of the reasons that you found the SUMO result to be consistently less than your model's results. Since the sumo model did not divide the inertia by r_wheel², the power calculation would have been underestimated. |
Hello everyone, in HelpersMMPEVEM.cpp, we calculate the mass factor of the vehicle which allows us to take rotating parts into account when using formulas for translational movement. Please note that we also divide by the vehicle mass and not just by the square of the wheel’s radius. |
To add a little bit to the confusion, the ElectricHybrid docs state that they use the |
Indeed. The authors of ElecHybrid obviously noticed that HelpersEnergy does not divide I by r^2. Therefore they redefine I as the "equivalent mass" that would compensate for the inertia. This equivalent mass is ordinarily calculated by dividing I by r^2. But since, I is not divided by r^2, they just redefined I as the equivalent mass. |
After consulting the thesis of the model author |
Closing here due to the upcoming release. The doc update now reflects more the original model definition and the physical relations. Discussions about the default values of battery device etc. continue in #13422 . |
Hi there. As stated in the docs, there is a model parameter called
internalMomentOfInertia
. This parameter, I, has units: kg·m². The correct way of calculating the power required for generating rotational inertia is:P = [ ½ * I/r_wheel^2 * (v^2 - v_old^2) ] / Δt
According to HelpersEnergy.cpp#L65, it is calculated differently... Instead of the factor I/r_wheel^2, it simply uses I.
On the other hand, the new MMPEVEM model calculates it correctly, as show in HelpersMMPEVEM.cpp#L83.
According to my calculations, SUMO's internalMomentOfInertia default, seems incorrect... The default is 0.01 kg·m². On the other hand, the values in the example configurations of MMPEVEM are in the magnitude of 12--16 kg·m², which are much closer to my calculations...
Something seems to be wrong somewhere with the modeling.
SUMO-version: 1.15
operating system: N/A
The text was updated successfully, but these errors were encountered: