Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failure to load vTypeDistribution #12846

Open
Tracked by #13112
, #13511
...
namdre opened this issue Mar 16, 2023 · 4 comments
Open
Tracked by #13112
, #13511
...

failure to load vTypeDistribution #12846

namdre opened this issue Mar 16, 2023 · 4 comments
Assignees
@palvarezlopez
Labels
a:netedit bug netedit:demandElements Label for netedit tickets centered in demand elements test needed
Milestone
1.20.0

Comments

@namdre
Copy link
Contributor

namdre commented Mar 16, 2023 •
edited

according to #9435, it should be possible to load vTypeDistributions.

However, trying to load the distributions in

tests/sumo/spec/distribution/vtype_basic and
tests/sumo/spec/distribution/vtypeDist_useExisting

fails with an error.

Properly supporting distributions opens up a number of interesting problems:

  • defining valid routes for vehicles that draw their type from a distribution with different vClasses
  • rendering of vehicles that draw their type form a distribution with different sizes/shapes etc.

related: #12845
@namdre namdre added a:netedit bug netedit:demandElements Label for netedit tickets centered in demand elements labels Mar 16, 2023
@namdre namdre mentioned this issue Mar 16, 2023
Closed
@namdre
Copy link
Contributor Author

namdre commented Mar 16, 2023

it also fails with #9435 so at least it isn't technically a regression.

@behrisch behrisch added this to the 1.17.0 milestone Mar 28, 2023
palvarezlopez added a commit that referenced this issue Apr 11, 2023
@palvarezlopez
Added vehicletype_distribution tests. Refs #12846
a329880
palvarezlopez added a commit that referenced this issue Apr 11, 2023
@palvarezlopez
Patching netedit expected results. Refs #12846 and #3045
151f5cc
@namdre
Copy link
Contributor Author

namdre commented Apr 11, 2023

Since loading still fails, I prefer to keep this open (rather than opening up a new ticket).

@namdre namdre reopened this Apr 11, 2023
@namdre namdre modified the milestones: 1.17.0, 1.18.0 Apr 11, 2023
@namdre namdre mentioned this issue May 16, 2023
Closed
21 tasks
@palvarezlopez palvarezlopez mentioned this issue Jun 8, 2023
Closed
palvarezlopez added a commit that referenced this issue Jun 8, 2023
@palvarezlopez
Updated writing of vTypeDistributions. Refs #12846
14262fb
palvarezlopez added a commit that referenced this issue Jun 8, 2023
@palvarezlopez
Updated writing of vTypeDistributions. Refs #12846
d5ce069
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Updated elements with type parents. Refs #12846
96eac36
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Now GNERouteHandler can load vTypeDistributions. Refs #12846
93014eb
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Updated GNERouteHandler(). Refs #12846
9f8add5
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Updated GNEVTypeDistribution. Refs #12846
41f7833
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Updated GNEDemandElement. Refs #12846
5c2e13a
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Fixed problem saving vTypeDistributions. Refs #12846
7554976
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Patching netedit expected results. Refs #12846 and #3045
1a729ec
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Updated GNEFrameAttributeModules::AttributesEditor. Refs #12846
c4d4adc
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Updated GNEVehicle. Refs #12846
40d3f53
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Updated GNERouteHandler::buildVType. Refs #12846
9e021d2
palvarezlopez added a commit that referenced this issue Jun 23, 2023
@palvarezlopez
Patching netedit expected results. Refs #12846 and #3045
ac5c40d
palvarezlopez added a commit that referenced this issue Jun 26, 2023
@palvarezlopez
Patching netedit expected results. Refs #12846 and #3045
4ce06f8
@palvarezlopez palvarezlopez mentioned this issue Jun 27, 2023
Closed
11 tasks
@palvarezlopez palvarezlopez modified the milestones: 1.18.0, 1.19.0 Jul 4, 2023
palvarezlopez added a commit that referenced this issue Jul 10, 2023
@palvarezlopez
Updated loading of typeDistributions. Refs #12846
90d3e6e
@namdre
Copy link
Contributor Author

namdre commented Jul 10, 2023

default probability of type is ignored when loading tests/sumo/spec/distribution/vtypeDist_useExisting (v1 should have probability 2 in distribution)

@namdre namdre reopened this Jul 10, 2023
palvarezlopez added a commit that referenced this issue Jul 11, 2023
@palvarezlopez
Updated load of default probabilities. Refs #12846
1150135
palvarezlopez added a commit that referenced this issue Jul 11, 2023
@palvarezlopez
Updated CommonXMLStructure. Added DoubleList. Refs #12846
399e289
palvarezlopez added a commit that referenced this issue Jul 11, 2023
@palvarezlopez
Updated buildVTypeDistribution. Refs #12846
77d80e9
palvarezlopez added a commit that referenced this issue Jul 11, 2023
@palvarezlopez
Patching netedit expected results. Refs #3045 and #12846
be9b033
@namdre
Copy link
Contributor Author

namdre commented Feb 2, 2024

loading tests/sumo/spec/distribution/vtypeDist_useExisting still fails

@namdre namdre reopened this Feb 2, 2024
@namdre namdre modified the milestones: 1.19.0, 1.20.0 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palvarezlopez palvarezlopez

Labels
a:netedit bug netedit:demandElements Label for netedit tickets centered in demand elements test needed
Projects
None yet
Milestone
1.20.0
Development

No branches or pull requests
3 participants
@behrisch @namdre @palvarezlopez