Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vehicle type missing in saved state and vehroute-output for vehicle added via TraCI #13384

Closed
namdre opened this issue Jun 7, 2023 · 2 comments

Comments

@namdre
Copy link
Contributor

namdre commented Jun 7, 2023

No description provided.

@namdre namdre self-assigned this Jun 7, 2023
@namdre namdre changed the title vehicle type missing in saved state for vehicle added via TraCI vehicle type missing in saved state and vehroute-output for vehicle added via TraCI Jun 7, 2023
namdre added a commit that referenced this issue Jun 7, 2023
@namdre namdre closed this as completed in 0af4c28 Jun 7, 2023
namdre added a commit that referenced this issue Jun 7, 2023
@bonni93
Copy link

bonni93 commented Jun 7, 2023

Hi, I think the patch works only if the type and vehicle ID are the same.
Example: if you have a vehicle with ID 'xx_0' but type 'xx', the saved state will have for both ID and type 'xx_0', and therefore you will have an error for type 'xx_0' not existing when trying to load that saved state in the same simulation. It could be circumvented by having one type for each vehicle added, but I think a more flexible approach would be to indeed show the type in the vehicle type statement within the saved state. That would correspond to a modification as:
vehicleParams.vtypeid = typeID;
on line 1522 of Vehicle.cpp

namdre added a commit that referenced this issue Jun 7, 2023
namdre added a commit that referenced this issue Jun 7, 2023
namdre added a commit that referenced this issue Jun 7, 2023
@namdre
Copy link
Contributor Author

namdre commented Jun 7, 2023

Thank you for spotting the typo!

@namdre namdre added the c:output label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants