Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major slowdown on windows #13561

Closed
namdre opened this issue Jul 5, 2023 · 3 comments
Closed

major slowdown on windows #13561

namdre opened this issue Jul 5, 2023 · 3 comments
Assignees
@namdre
Labels
a:sumo bug p:critical more important that 'important' but not 'blocker' regression Works in previous versions
Milestone
1.19.0

Comments

@namdre
Copy link
Contributor

namdre commented Jul 5, 2023 •
edited

observed in cf_model/fundamental/krauss_t0.9_s0.8

on windows:
1.15.0: ~5s
1.16.0: ~22s
dev: ~22s

on Linux the running time is the same for the three versions (~5s).
@namdre
Copy link
Contributor Author

namdre commented Jul 5, 2023

the slowdown disappears when I build sumo without internationalization (1.16.0 was the first release with internationalization)

@namdre namdre added the p:critical more important that 'important' but not 'blocker' label Jul 5, 2023
@namdre namdre added this to the 1.19.0 milestone Jul 5, 2023
@namdre
Copy link
Contributor Author

namdre commented Jul 5, 2023

Dependency on internationalization confirmed on another windows machine.

namdre added a commit that referenced this issue Jul 5, 2023
@namdre
avoid premature translation. refs #13561
158501e
@namdre namdre added the regression Works in previous versions label Jul 5, 2023
@namdre namdre assigned namdre and unassigned behrisch Jul 5, 2023
@namdre
Copy link
Contributor Author

namdre commented Jul 5, 2023

The moral here is to never perform translations before it is actually needed.

@namdre namdre closed this as completed Jul 5, 2023
@namdre namdre mentioned this issue Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namdre namdre

Labels
a:sumo bug p:critical more important that 'important' but not 'blocker' regression Works in previous versions
Projects
None yet
Milestone
1.19.0
Development

No branches or pull requests
2 participants
@behrisch @namdre