Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable speed signs are disregarded when using vehicle class limits from edge type #13652

Closed
yuameier111 opened this issue Jul 24, 2023 · 4 comments
Closed

Variable speed signs are disregarded when using vehicle class limits from edge type #13652

yuameier111 opened this issue Jul 24, 2023 · 4 comments
Assignees
@m-kro
Labels
a:sumo bug p:important more important than default but not 'critical'
Milestone
1.19.0

Comments

@yuameier111
Copy link

yuameier111 commented Jul 24, 2023 •
edited by angelobanse

hello, here is my vss code and the videorecord. Why the vehicles can't stop as the speed limit?

test.mp4

test.zip
@m-kro m-kro self-assigned this Jul 24, 2023
@m-kro m-kro added a:sumo bug p:important more important than default but not 'critical' labels Jul 24, 2023
@m-kro m-kro added this to the 1.19.0 milestone Jul 24, 2023
@m-kro m-kro changed the title the vss didn't work Variable speed signs are disregarded by vehicle class other than passenger Jul 24, 2023
@m-kro m-kro changed the title Variable speed signs are disregarded by vehicle class other than passenger Variable speed signs are disregarded when using vehicle class limits from edge type Jul 24, 2023
@m-kro
Copy link
Contributor

m-kro commented Jul 24, 2023 •
edited

Sorry for overlooking the actual problem the first time. We have to resolve a priority problem between the different ways to set the lane speed in the code. This triggers the problem:

  • you have set edge types with speed limits for different vehicle classes
  • these limits currently still overwrite the speed limit coming from the variable speed sign

If you need to work around the problem urgently, please consider removing the edge type speed restrictions from the edges you control via variable speed signs.

m-kro added a commit that referenced this issue Jul 24, 2023
@m-kro
absolute precedence for variable speed sign (microsim) ref #13652
22637e2 
Signed-off-by: m-kro <m.barthauer@t-online.de>
@m-kro
Copy link
Contributor

m-kro commented Jul 25, 2023

@yuameier111 You can try the development version from our website which makes the vehicles stop in your scenario.

@m-kro m-kro closed this as completed Jul 25, 2023
@m-kro m-kro mentioned this issue Jul 26, 2023
Closed
@namdre
Copy link
Contributor

namdre commented Feb 19, 2024

Can we get a test on this? I think the logic might be the wrong way around since it uses isDefault as mySpeedByVSS (which I think is true when the VSS hands back control)

@namdre namdre reopened this Feb 19, 2024
m-kro added a commit that referenced this issue Feb 19, 2024
@m-kro
correct condition #13652
d5aadc9 
Signed-off-by: m-kro <m.barthauer@t-online.de>
m-kro added a commit that referenced this issue Feb 19, 2024
@m-kro
test stub for ref #13652
165216b 
Signed-off-by: m-kro <m.barthauer@t-online.de>
m-kro added a commit that referenced this issue Feb 19, 2024
@m-kro
update test ref #21 #13652
d7cba1b 
Signed-off-by: m-kro <m.barthauer@t-online.de>
@m-kro
Copy link
Contributor

m-kro commented Feb 19, 2024

You are right, is was wrong way around.

m-kro added a commit that referenced this issue Feb 20, 2024
@m-kro
patch test ref #21 #13652
9ce87be 
Signed-off-by: m-kro <m.barthauer@t-online.de>
@namdre namdre closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-kro m-kro

Labels
a:sumo bug p:important more important than default but not 'critical'
Projects
None yet
Milestone
1.19.0
Development

No branches or pull requests
3 participants
@namdre @m-kro @yuameier111