Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scooter visualisation (gui shape) not aligned and scaled correctly #13691

Closed
pascalbrunner opened this issue Aug 4, 2023 · 4 comments
Closed
Assignees
Milestone

Comments

@pascalbrunner
Copy link

pascalbrunner commented Aug 4, 2023

Sometimes it showed an accident in the gui were the bike and car did not touch, so I tried to figure out the problem.

The position of a car is defined as the front bumper.
The position of a bike is defined as the center (but should probably also be the front bumper).
I assume the script for calculating the collision thinks that the position of the bike is the front bumper.
Please review, I think this can be fixed quite fast. Thank you!

SUMO-version: 1.17.0

operating system: Windows 10

@m-kro m-kro added the a:sumo label Aug 4, 2023
@m-kro
Copy link
Contributor

m-kro commented Aug 4, 2023

Could you please share your example files here so that it takes less time to reproduce?

@m-kro
Copy link
Contributor

m-kro commented Aug 15, 2023

Closing due to inactivity. Please write here again if you have more information.

@pascalbrunner
Copy link
Author

pascalbrunner commented Sep 12, 2023

Hi,

sorry for my late reply. I could now track down the issue.
It is just a visualization problem when using guiShape=scooter.
The shape of the scooter has the center as position point, while the shape of the bike has the front bumper as the position point.
I attached two pictures in which you can see by changing between the "standard" and "real world" view, that the position jumpes.
I also attached a traci script to your example "sumolympics" and modified the flow file.
This could help for debugging.
I will just switch the view again to standard, but I nevertheless wanted to tell you this issue which could be fixed quite fast probably.

All the best,
Pascal

data.zip
pic1
pic2

@m-kro m-kro reopened this Sep 12, 2023
@m-kro m-kro changed the title Bike Bounding Boxes are calculated wrong Reference position of scooter visualisation not aligned to front Sep 12, 2023
@m-kro m-kro changed the title Reference position of scooter visualisation not aligned to front Reference position of bike visualisation not aligned to front Sep 12, 2023
@behrisch behrisch added this to the 1.20.0 milestone Dec 19, 2023
m-kro added a commit that referenced this issue Dec 19, 2023
Signed-off-by: m-kro <m.barthauer@t-online.de>
@m-kro
Copy link
Contributor

m-kro commented Dec 19, 2023

The shape offset has been changed (shifted upstream) but the scooter seems as well to small compared to the triangle representation.

@m-kro m-kro changed the title Reference position of bike visualisation not aligned to front Scooter visualisation not aligned and scaled correctly Dec 20, 2023
@m-kro m-kro changed the title Scooter visualisation not aligned and scaled correctly Scooter visualisation (gui shape) not aligned and scaled correctly Dec 20, 2023
m-kro added a commit that referenced this issue Dec 20, 2023
Signed-off-by: m-kro <m.barthauer@t-online.de>
@m-kro m-kro closed this as completed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants