Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vehicles don't overtake leader controlled by TraCI #13710

Closed
m-kro opened this issue Aug 14, 2023 · 4 comments
Closed

Vehicles don't overtake leader controlled by TraCI #13710

m-kro opened this issue Aug 14, 2023 · 4 comments
Assignees
@m-kro
Labels
bug c:opposite_direction c:traci sumo-user
Milestone
1.19.0

Comments

@m-kro
Copy link
Contributor

m-kro commented Aug 14, 2023

Reported on the mailing list. Vehicles travel on a lane with no vehicle on the opposite neighbour lane when the leader vehicle is stopped by traci.vehicle.slowDown and kept at the stand-still position by traci.vehicle.setSpeed(vehID, 0).
The following vehicles will stop behind it and not try to overtake, which they do if the leader vehicle stops at a regular stop (either defined in XML or through traci.vehicle.setStop).
@m-kro
Copy link
Contributor Author

m-kro commented Aug 15, 2023

This overtaking case is catched by conditions introduced with #10360 , specifically this time threshold:

https://github.com/eclipse/sumo/blob/f01a34745f91df2e29f5be3ed698e81b0f91130c/src/microsim/MSLaneChanger.cpp#L57

@m-kro m-kro self-assigned this Aug 15, 2023
@m-kro m-kro added this to the 1.20.0 milestone Aug 15, 2023
@m-kro m-kro added the bug label Aug 15, 2023
@m-kro m-kro modified the milestones: 1.20.0, 1.19.0 Aug 15, 2023
m-kro added a commit that referenced this issue Aug 15, 2023
@m-kro
loosen conditions for overtaking on the opposite lane w/o traffic ref #…
671ef88 
…13710

Signed-off-by: m-kro <m.barthauer@t-online.de>
@m-kro
Copy link
Contributor Author

m-kro commented Aug 17, 2023

Seems to work, so let's close the issue

@m-kro m-kro closed this as completed Aug 17, 2023
@behrisch
Copy link
Contributor

behrisch commented Nov 6, 2023

@m-kro can we get a test from the user scenario (or your own) here?

m-kro added a commit that referenced this issue Nov 6, 2023
@m-kro
add test ref #21 #13710
47f2813 
Signed-off-by: m-kro <m.barthauer@t-online.de>
@m-kro
Copy link
Contributor Author

m-kro commented Nov 6, 2023

Added the test

@m-kro m-kro removed the test needed label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-kro m-kro

Labels
bug c:opposite_direction c:traci sumo-user
Projects
None yet
Milestone
1.19.0
Development

No branches or pull requests
2 participants
@behrisch @m-kro