Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing connections after adding edge #14391

Closed
namdre opened this issue Feb 22, 2024 · 6 comments
Closed

missing connections after adding edge #14391

namdre opened this issue Feb 22, 2024 · 6 comments
Assignees
Labels
a:netedit bug netedit:netElements Label for netedit tickets centered in net elements p:blocker Maximum priority. Development cannot continue until fixing. regression Works in previous versions
Milestone

Comments

@namdre
Copy link
Contributor

namdre commented Feb 22, 2024

  • create an edge
  • F5
  • create a second edge outgoing of the first
  • F5

Expectation (working in 1.18): there is a connection between the edges
Observation (1.19): missing connection

I'm guessing this is closer to the root cause for #13699

@namdre namdre added p:critical more important that 'important' but not 'blocker' a:netedit bug regression Works in previous versions netedit:netElements Label for netedit tickets centered in net elements p:blocker Maximum priority. Development cannot continue until fixing. and removed p:critical more important that 'important' but not 'blocker' labels Feb 22, 2024
@namdre
Copy link
Contributor Author

namdre commented Feb 22, 2024

level of criticality: If nothing else we're broken I would want to do a hotfix release for this!

@namdre namdre self-assigned this Feb 22, 2024
@namdre
Copy link
Contributor Author

namdre commented Feb 22, 2024

@palvarezlopez I'll do a git bisect but will probably have to discuss things with you.

@namdre
Copy link
Contributor Author

namdre commented Feb 22, 2024

It's a mess. The problem could be anywhere between 5f1b4ae and 36d4c2a. In between, the build is broken (at least on linux). Thats 47 candidate commits. Full bisect log is attached
14391.bisectlog.txt

and here is a combined diff for all the candidate commits: https://github.com/eclipse-sumo/sumo/compare/5f1b4aee02e35f9bacf83d4ce0c3ee530038a9eb..36d4c2a168a82493398ef4dd0e14fcb1e8b74e38

@namdre namdre added this to the 1.20.0 milestone Feb 23, 2024
@palvarezlopez
Copy link
Member

@namdre can you filter in the bisect all #13667 tickets? (is the JuPedSim Ticket)

@namdre
Copy link
Contributor Author

namdre commented Mar 4, 2024

I cannot filter the diff any further. However, if you can (locally) fix the build for versions between the last known good and the first known bad version, you can check whether they are affected by the problem an we can get a smaller range and shorter diff.

@palvarezlopez
Copy link
Member

Broken in 436f243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:netedit bug netedit:netElements Label for netedit tickets centered in net elements p:blocker Maximum priority. Development cannot continue until fixing. regression Works in previous versions
Projects
None yet
Development

No branches or pull requests

2 participants