Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid "save" dialog after loading additionals #14464

Closed
namdre opened this issue Mar 5, 2024 · 2 comments
Closed

invalid "save" dialog after loading additionals #14464

namdre opened this issue Mar 5, 2024 · 2 comments
Assignees
Labels
a:netedit bug netedit:additionalElements Label for netedit tickets centered in additional elements regression Works in previous versions
Milestone

Comments

@namdre
Copy link
Contributor

namdre commented Mar 5, 2024

if nothing is modified, the dialog shouldn't come up. Last working in 1.15.0

@namdre namdre added a:netedit bug regression Works in previous versions netedit:additionalElements Label for netedit tickets centered in additional elements labels Mar 5, 2024
@namdre namdre added this to the 1.20.0 milestone Mar 5, 2024
@namdre namdre self-assigned this Mar 5, 2024
@palvarezlopez
Copy link
Member

If I remember correctly, we activated this option for the case in which we load two different additional files from two differents sources (example: One file with detectors and another with busStops).

There is a middle solution, and is only enable the save dialog after loading additional, if previously there are at least one additional in the network. What do you mean?

@namdre
Copy link
Contributor Author

namdre commented Mar 5, 2024

I'm only talking about the case of loading a single additional file and this was working as expected earlier. I don't mind having the behavior you describe (only open save-dialog if there are more additionals then those loaded from a single file).

There is again a bit of a mess of unbuildable commits in the repo so the exact problem commit is unclear: https://github.com/eclipse-sumo/sumo/compare/720fba3fc00cab8be8a9bae121b731fb4fef8cc3..ff202ad6abe746a8d2041b68e25fc798d1132e45

The behavior changed somewhere during implementation of #11896 (see bisect log below). Since there is no ticket reference for an intentional change in behavior I doubt that it was intended.

# possible first bad commit: [ff202ad6abe746a8d2041b68e25fc798d1132e45] fixing gcc build. refs #3
# possible first bad commit: [659caa698852d81c1e88afc8a1f32c6c5a78444c] added tests refs #12304, #21
# possible first bad commit: [336bea6ca36419ea6d324a29c028a3b16103dec8] #2 doc #12304
# possible first bad commit: [21f79d3d3d2a2edd2329182e3d7e9a4b057d4577] Fixed problem loading networks in GNEConfigHandler::loadConfig(). Refs #11896
# possible first bad commit: [8e8e100f43b0fc36d6452e0503c375c729d89e3f] Added resetDefault() function in OptionsCont. Refs #11896
# possible first bad commit: [6cb290a56e19bc9cf10d5d0439b707bf21fc1149] Updated mySUMOOptions. Refs #11896
# possible first bad commit: [3313270b1a890cce83a4c7d0524ae41e1b464794] Now SUMOConfigs can be saved. Refs #11896
# possible first bad commit: [ef61d7fbec934eb75691390aa18b38cdd896f924] Fixed invalid warning. Refs #11896
# possible first bad commit: [9eb94bac53193ed1025cc7c760ed609233138752] Updated GNEConfigHandler::loadConfig(). Refs #11896
# possible first bad commit: [6f01e9be2654ad52e23624ed69630c59ae69adda] Updated GNEMeanDataHandler and GNEGeneralHandler. Refs #11896
# possible first bad commit: [720fba3fc00cab8be8a9bae121b731fb4fef8cc3] Updated MeanDataHandler(). Refs #11896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:netedit bug netedit:additionalElements Label for netedit tickets centered in additional elements regression Works in previous versions
Projects
None yet
Development

No branches or pull requests

2 participants