Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve import of waterbodies and harbours #14597

Closed
namdre opened this issue Mar 26, 2024 · 2 comments
Closed

improve import of waterbodies and harbours #14597

namdre opened this issue Mar 26, 2024 · 2 comments
Assignees
@namdre
Labels
a:polyconvert enhancement
Milestone
backlog

Comments

@namdre
Copy link
Contributor

namdre commented Mar 26, 2024

looks ugly at the moment
@namdre namdre self-assigned this Mar 26, 2024
@namdre namdre added this to the backlog milestone Mar 26, 2024
@namdre
Copy link
Contributor Author

namdre commented Mar 26, 2024

it's complicated: coastlines are assembled from many parts and there are dedicated projects to make sense of them: https://osmdata.openstreetmap.de/data/water-polygons.html

namdre added a commit that referenced this issue Mar 26, 2024
@namdre
improving waterbody coloring and layering. refs #14597
0c41b5f
namdre added a commit that referenced this issue Mar 26, 2024
@namdre
improved assembly of multipart polygons. refs #14597
54300f1
namdre added a commit that referenced this issue Mar 26, 2024
@namdre
patching expected results refs #21, #14597
1b122d1
@namdre namdre mentioned this issue Mar 27, 2024
Closed
@namdre
Copy link
Contributor Author

namdre commented Mar 27, 2024

with the new code, coastlines look great wit! (with --osm.merge-relations)
it seems the remaining issues come form #14598

namdre added a commit that referenced this issue Mar 27, 2024
@namdre
merging relations by default. refs #14597
135a212
@namdre namdre closed this as completed Mar 27, 2024
namdre added a commit that referenced this issue Apr 24, 2024
@namdre
added test refs #14597
13a295f
namdre added a commit that referenced this issue Apr 24, 2024
@namdre
polyconvert typemap now supports fill=force. refs #14597
88cce39
namdre added a commit that referenced this issue Apr 24, 2024
@namdre
forcing some polygons to always be filled even when incomplete. refs #…
76124ad 
…14597
namdre added a commit that referenced this issue Apr 25, 2024
@namdre
patching expected results refs #21, #14597
e2cd4c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namdre namdre

Labels
a:polyconvert enhancement
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
1 participant
@namdre