Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified poisson rate in flow creation mode #14648

Closed
namdre opened this issue Apr 2, 2024 · 4 comments
Closed

modified poisson rate in flow creation mode #14648

namdre opened this issue Apr 2, 2024 · 4 comments
Assignees
@namdre @palvarezlopez
Labels
a:netedit bug netedit:demandElements Label for netedit tickets centered in demand elements regression Works in previous versions
Milestone
1.20.0

Comments

@namdre
Copy link
Contributor

namdre commented Apr 2, 2024

a value of 1.5 will be changed to 1.49925037481259360028
@namdre namdre added a:netedit bug netedit:demandElements Label for netedit tickets centered in demand elements regression Works in previous versions labels Apr 2, 2024
@namdre
Copy link
Contributor Author

namdre commented Apr 2, 2024

regression in 1.19.0

@namdre namdre added this to the 1.20.0 milestone Apr 2, 2024
@namdre
Copy link
Contributor Author

namdre commented Apr 2, 2024

this is numerical problem that comes from converting between the Poisson rate and it's inverse (the analogue to a repetitionOffset). This was done to easily convert between different spacing but creates problem due to the truncation to ms which isn't precise enough for rates above 1.

@namdre
Copy link
Contributor Author

namdre commented Apr 2, 2024

proposed solutions

  • a) store the rate directly in the repetitionOffset (no inverse) and do the conversion only when switching between spacing styles
  • b) store the rate as a double value in GNEDemandElementFlow and only do conversions when converting between spacing styles

@namdre namdre mentioned this issue Apr 8, 2024
Closed
@palvarezlopez palvarezlopez self-assigned this Apr 8, 2024
@namdre namdre self-assigned this Apr 8, 2024
@namdre
Copy link
Contributor Author

namdre commented Apr 9, 2024

fixed via #14664

@namdre namdre closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namdre namdre

@palvarezlopez palvarezlopez

Labels
a:netedit bug netedit:demandElements Label for netedit tickets centered in demand elements regression Works in previous versions
Projects
None yet
Milestone
1.20.0
Development

No branches or pull requests
2 participants
@namdre @palvarezlopez