improve node shape computer (trac #2551)

[behrisch]

as suggest by Yifeng Zeng, commenting out the below lines in NBNodeShapeComputer makes many junctions prettier (by making them longer)

 SUMOReal mmin = MIN2(distances[*cwi], distances[*ccwi]);
 if (mmin > 100) {
     distances[*i] = (SUMOReal) 5. + (SUMOReal) 100. - (SUMOReal)(mmin - 100); //100 + 1.5;
 }

One counterexample is in tests/netconvert/node_building/node_shape/2way_with_smoothly_merging_lane (where the junction shape breaks)

Migrated from http://sumo.dlr.de/ticket/2551

{
    "status": "closed", 
    "changetime": "2017-04-25T07:15:49Z", 
    "description": "as suggest by Yifeng Zeng, commenting out the below lines in NBNodeShapeComputer makes many junctions prettier (by making them longer)\n\n     SUMOReal mmin = MIN2(distances[*cwi], distances[*ccwi]);\n     if (mmin > 100) {\n         distances[*i] = (SUMOReal) 5. + (SUMOReal) 100. - (SUMOReal)(mmin - 100); //100 + 1.5;\n     }\n\nOne counterexample is in tests/netconvert/node_building/node_shape/2way_with_smoothly_merging_lane (where the junction shape breaks)", 
    "reporter": "namdre", 
    "cc": "", 
    "resolution": "fixed", 
    "_ts": "1493104549669397", 
    "component": "net building (NETGEN, NETCONVERT)", 
    "summary": "improve node shape computer", 
    "priority": "minor", 
    "keywords": "", 
    "time": "2016-09-13T11:01:20Z", 
    "milestone": "0.30.0", 
    "owner": "namdre", 
    "type": "defect"
}

[behrisch]

• @behrisch changed milestone from "0.28.0" to "0.29.0"
• @behrisch changed owner from "" to "namdre"
• @behrisch changed status from "new" to "assigned"

[behrisch]

• @www-data committed 28a7e2b (aka r23025):
  fix improve node shape computer (trac #2551) #2551
• @www-data changed resolution from "" to "fixed"
• @www-data changed status from "assigned" to "closed"

[behrisch]

@behrisch changed milestone from "1.0.0" to "0.30.0"