Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework declearation of cf-model in rou.xml (trac #663) #663

Closed
behrisch opened this issue Feb 7, 2012 · 6 comments
Closed

Rework declearation of cf-model in rou.xml (trac #663) #663

behrisch opened this issue Feb 7, 2012 · 6 comments

Comments

@behrisch
Copy link
Contributor

behrisch commented Feb 7, 2012

Right now, the car-follow model has to be specified in a child element named after the model and model-specific attributes.
i.e. <carFollowing-IDM .../>

As an exception from the rule, the parameters of the default cf-model "carFollowing-Krauss" may also be specified in the element.

For sake of consistency it would be nice to add the attribute
"carFollowModel" to and allow setting all model specific attributes in the vType element.

Migrated from http://sumo.dlr.de/ticket/663

{
    "status": "closed", 
    "changetime": "2015-07-03T10:44:54Z", 
    "description": "Right now, the car-follow model has to be specified in a child element named after the model and model-specific attributes.\ni.e. <carFollowing-IDM .../>\n\nAs an exception from the rule, the parameters of the default cf-model \"carFollowing-Krauss\" may also be specified in the <vType> element.\n\nFor sake of consistency it would be nice to add the attribute\n\"carFollowModel\" to <vType> and allow setting all model specific attributes in the vType element.\n\n", 
    "reporter": "namdre", 
    "cc": "", 
    "resolution": "fixed", 
    "_ts": "1435920294480235", 
    "component": "simulation data input", 
    "summary": "Rework declearation of cf-model in rou.xml", 
    "priority": "minor", 
    "keywords": "", 
    "time": "2012-02-07T10:18:17Z", 
    "milestone": "1.0.0", 
    "owner": "", 
    "type": "enhancement"
}
@behrisch
Copy link
Contributor Author

behrisch commented Feb 7, 2012

@bjhend commented:

+1

The model name as part of a tag name is particularly annoying if you've implemented part of your special project functionality in a special model derived from a provided model. To do this I had to add direct and indirect references to my special model tag name in several files and recheck them after every SUMO update making the update more tedious.

@behrisch
Copy link
Contributor Author

behrisch commented Feb 7, 2012

updated priority since somebody cares (-:
Not sure when i get around to it, though.

  • @namdre changed priority from "trivial" to "minor"

@behrisch
Copy link
Contributor Author

behrisch commented Feb 7, 2012

@behrisch committed 5a7c283 (aka r18516):
better cfmodel parsing and writing, refs #663, 1832

@behrisch
Copy link
Contributor Author

behrisch commented Feb 7, 2012

@behrisch committed 23881e5 (aka r18525):
fixing cfmodel attribute parse, refs #663

@behrisch
Copy link
Contributor Author

behrisch commented Feb 7, 2012

@behrisch committed 8f56d95 (aka r18526):
adapting schema to cfmodel inside type definition, refs #663, #2

@behrisch
Copy link
Contributor Author

behrisch commented Feb 7, 2012

  • @behrisch changed resolution from "" to "fixed"
  • @behrisch changed status from "new" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant