Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of node removal checks #8270

Closed
behrisch opened this issue Feb 23, 2021 · 3 comments
Closed

Improve performance of node removal checks #8270

behrisch opened this issue Feb 23, 2021 · 3 comments
Assignees
@namdre
Labels
a:netconvert enhancement

Comments

@behrisch
Copy link
Contributor

iterating over all pt stops whenever an edge is merged seems to slow down the process
@namdre namdre self-assigned this Feb 24, 2021
@namdre namdre closed this as completed in dba1812 Feb 24, 2021
@namdre
Copy link
Contributor

namdre commented Feb 24, 2021 •
edited
Loading

  • previous time to build network: 11:46
  • time with sc.replaceEdge disabled: 9:8
  • new code with lookup table: 9:19
  • time with -R false: 7:20 (so node removal itself is pretty expensive)

namdre added a commit that referenced this issue Mar 2, 2021
@namdre
fixed slow node removal check for network with many traffic lights. r…
b2d5f8e 
…efs #8270
@behrisch
Copy link
Contributor Author

behrisch commented Mar 3, 2021

Are there new network build time numbers?

@namdre
Copy link
Contributor

namdre commented Mar 3, 2021

  • new time for berlin: 6:44
  • the time for the 'germany'-network was reduced from 150min to 6min

@namdre namdre mentioned this issue Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namdre namdre

Labels
a:netconvert enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behrisch @namdre