Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README #5764

Closed
wants to merge 3 commits into from
Closed

Updated README #5764

wants to merge 3 commits into from

Conversation

sunn-e
Copy link

@sunn-e sunn-e commented Jun 25, 2019

added direct download link.
Formatted the document according to standard.

Added a direct download links.
Formatted according to standard.
@sunn-e
Copy link
Author

sunn-e commented Jun 25, 2019

I signed the legal documents. https://accounts.eclipse.org/users/sdhoke/

@sunn-e
Copy link
Author

sunn-e commented Jun 25, 2019

@namdre

@sunn-e sunn-e closed this Jun 25, 2019
@sunn-e sunn-e reopened this Jun 25, 2019
@namdre
Copy link
Contributor

namdre commented Jun 25, 2019

The eclipse-IP-checker rejects your commit due to the following error: Sunny Dhoke did not include the "Signed-off-by footer" which is required for all commits made by a contributor.
Also, please wait for @behrisch to review your changes because he's responsible for that document.

@namdre namdre requested a review from behrisch June 25, 2019 14:59
@sunn-e
Copy link
Author

sunn-e commented Jun 26, 2019

Thank you for the reply @namdre . What does " “Signed-off-by” footer in commit messages mean? How do I add it now? This is my first time with Eclipse foundation so please forgive me if it's a naive question. I tried finding the answer but coul not find it. I pushed my commit without confirming my account so I think ECA Github app didnt know I signed ECA.

@namdre
Copy link
Contributor

namdre commented Jun 26, 2019

See https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for,
https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#via_GitHub

There may be a git way of retroactively amending the commits but I'm afraid the easiest way is to re-clone and re-issue the pull request.

Sorry for the hassle but this is the Eclipse.org way of hardening the code base against lawsuits.

@sunn-e
Copy link
Author

sunn-e commented Jun 26, 2019

WOW. Thanks for the links @namdre . This will be a memorable day for me as an open source contributor. I had no idea that such incidents have happened and have not been settled yet. The article about SCO vs IBM was worth a read for me.
Coming back to my PR, No problem, I will resend my PR. I will till then wait for the review and see if I could improve the doc.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants