feat(MyProjectsUI):Add additional filter to My Projects homepage based on project clearing state. #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smrutis1
requested changes
Mar 12, 2021
...w360-portlet/src/main/java/org/eclipse/sw360/portal/portlets/homepage/MyProjectsPortlet.java
Outdated
Show resolved
Hide resolved
| @@ -66,7 +66,25 @@ | |||
| <core_rt:if test="${userRoles==null||userRoles.SECURITY_RESPONSIBLES}">checked="checked"</core_rt:if>> | |||
| <label class="form-check-label" for="securityResponsible">Security Responsible</label> | |||
| </li> | |||
| <li><hr class="my-2" /></li> | |||
| <li class="dropdown-header">Clearing State</li> | |||
There was a problem hiding this comment.
It would be good to read the labels from i18N properties.
There was a problem hiding this comment.
Followed the existing approach,which is working in production for roles label.
There was a problem hiding this comment.
hm, it was for internationalization. But it's ok for now.
...w360-portlet/src/main/java/org/eclipse/sw360/portal/portlets/homepage/MyProjectsPortlet.java
Outdated
Show resolved
Hide resolved
...w360-portlet/src/main/java/org/eclipse/sw360/portal/portlets/homepage/MyProjectsPortlet.java
Outdated
Show resolved
Hide resolved
ravi110336
force-pushed
the
feat/MyProjectsFiltering
branch
3 times, most recently
from
6188c6a
to
68fbfe3
Compare
…d on clearing state. Signed-off-by: ravi110336 <kumar.ravindra@siemens.com>
ravi110336
force-pushed
the
feat/MyProjectsFiltering
branch
from
68fbfe3
to
0b7818d
Compare
smrutis1
approved these changes
Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Suggest Reviewer
How To Test?
Checklist
Must:
Signed-off-by: Ravindra Kumar kumar.ravindra@siemens.com