Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ObligationHelpTextforProject): Provide the different obligation help text from the Projects Screen under Obligations tab. #1238

Merged
merged 1 commit into from Jun 4, 2021
Merged

feat(ObligationHelpTextforProject): Provide the different obligation help text from the Projects Screen under Obligations tab. #1238

merged 1 commit into from Jun 4, 2021

Conversation

ravi110336
Copy link
Contributor

@ravi110336 ravi110336 commented Jun 1, 2021 •
edited

Please provide a summary of your changes here.

Issue: closes #1237

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

How should these changes be tested by the reviewer?

  • To Test this go to Projects->Obligations
  • Validate the different help text for the License Obligation, Project obligation, Component obligation, Organistion Obligation.
    image

Have you implemented any additional tests? NA

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

Signed-off-by: ravi110336 kumar.ravindra@siemens.com

@ravi110336 ravi110336 changed the title feat(ObligationHelpTextforProject): Provide the different obligation help text from the Projects Screen under Obligations tab.b. feat(ObligationHelpTextforProject): Provide the different obligation help text from the Projects Screen under Obligations tab. Jun 1, 2021
@mcjaeger mcjaeger added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jun 2, 2021
@akapti akapti added this to Preparing in Pull Request Board via automation Jun 3, 2021
@akapti akapti moved this from Preparing to Ready for test in Pull Request Board Jun 3, 2021
@akapti akapti self-requested a review June 3, 2021 05:18
akapti
akapti reviewed Jun 3, 2021
View reviewed changes
Copy link
Contributor

@akapti akapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the PR, working as expected.

suggest one minor change, Kindly look into it.

...rtlet/src/main/resources/META-INF/resources/html/projects/includes/projects/obligations.jspf Outdated
@@ -131,7 +137,9 @@
<th class="org-more-info">
<span title="<liferay-ui:message key="expand.all" />" data-show="false">&#x25BA</span>
</th>
<th><liferay-ui:message key="organisation.obligation" /></th>
<th>
<span title="<liferay-ui:message key="ObligationLevel-ORGANISATION_OBLIGATION" />" data-show="false"><liferay-ui:message key="organisation.obligation" /></span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any significance of the attribute data-show="false" ?
please remove it from all the 4 span, if it's not used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akapti Thanks for the review and test, removed the unwanted code, Please check.

@akapti akapti moved this from Ready for test to Changes Requested in Pull Request Board Jun 3, 2021
@akapti akapti removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jun 3, 2021
feat(ObligationHelpTextforProject): Provide the different obligation …
276650a 
…help text from the Projects Screen.

Signed-off-by: ravi110336 <kumar.ravindra@siemens.com>
@ravi110336 ravi110336 force-pushed the feat/ObligationHelpTextForProject branch from a50a70e to 276650a Compare June 3, 2021 06:13
akapti
akapti approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@akapti akapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Pull Request Board automation moved this from Changes Requested to Ready for test Jun 3, 2021
@akapti akapti moved this from Ready for test to Reviewer approved in Pull Request Board Jun 3, 2021
@akapti akapti added the ready ready to merge label Jun 3, 2021
@smrutis1 smrutis1 merged commit 668d81c into eclipse-sw360:master Jun 4, 2021
Pull Request Board automation moved this from Reviewer approved to Merged to master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akapti akapti akapti approved these changes

Assignees
No one assigned
Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obligation help text tooltip are not showing from the Projects Screen.
4 participants
@ravi110336 @akapti @mcjaeger @smrutis1