Bug 462185 - Adopt new plugin syntax for config.xml #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue tracker reference: |
| featureParamsTableViewer.setInput(event.getNewValue()); | ||
| } | ||
| }); | ||
| // Feature feature = (Feature)sel.getFirstElement(); |
There was a problem hiding this comment.
These lines are commented out because tags do not have parameters. I wasn't sure if we wanted to remove the parameters section / the whole page altogether, so I've left it in for now.
Add Plugin class to represent <Plugin> tag in config.xml. Change PropertiesPage to correctly show this new class, and hook existing buttons to plugin management. Previous Feature class still exists, but is no longer used. Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=462185 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Plugin class to represent tag in config.xml. Change
PropertiesPage to correctly show this new class, and hook existing
buttons to plugin management. Previous Feature class still exists,
but is no longer used.
Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=462185
Signed-off-by: Angel Misevski amisevsk@redhat.com