Fix #462 Delay Pom considered items to the final Target Platform calculation

[laeubi]

Signed-off-by: Christoph Läubrich laeubi@laeubi-soft.de

[github-actions]

Unit Test Results

144 files  144 suites   49m 33s ⏱️
229 tests 226 ✔️ 3 💤 0 ❌

Results for commit 1609a1a.

♻️ This comment has been updated with latest results.

[laeubi]

@mickaelistria this moves pom dependency metat-data computation out of the "maven-setup-phase" into the "target-resoloution-phase" and thus delays it until the final maven build starts.

This will (after some adjustments) fix the long outstanding issue that tycho is not able to consumer "pom-first" bundles together with tycho ones in the same reactor build.

[laeubi]

All integration tests are green now, so from my side this is ready to go.
Even if there are some special cases where this not work, the maven-target location offers a more feature-rich opportunity to reference maven-dependencies in a tycho build.

[mickaelistria]

We need to discuss #462 (comment) before merging anything. I'm afraid this could bring regressions.

[laeubi]

We need to discuss #462 (comment) before merging anything. I'm afraid this could bring regressions.

Are you aware of any project using pomDependencies=consider in a larger context so I could check with these? I really don't want to support to much possible use case that are actually never used and not covered by test and given that there are alternatives that could be used to get back the old behavior I wont mind even a breaking change...

[laeubi]

@HannesWell do you want to try this out with m2e build to gather some more experience beyond the simple integration test?

[HannesWell]

@HannesWell do you want to try this out with m2e build to gather some more experience beyond the simple integration test?

Yes, I will test it with the m2e build.

[mickaelistria]

Some minimal suggestions inline.
Also, please add documentation to TargetPlatformConfigurationMojo#pomDependencies to explicit how pom dependencies are now expected to participate or not in the resolution.

[laeubi]

/rebase

[laeubi]

@mickaelistria I rebased this now on your change regarding local file transfers.

[laeubi]

only org.eclipse.tycho.test.product.ProductBuildTest is failing now @mickaelistria any hint what could be the cause?

[mickaelistria]

See https://ci.eclipse.org/tycho/job/tycho-github/job/PR-470/28/#showFailuresLink ; ProductMixedVersionTest also fails with the same reason. The Maven artifacts are not visible into the "blackboard" repository used by p2 director.

[laeubi]

okay found it, everything green now.

[mickaelistria]

This looks good to merge soon, can you please squash the commits and add a commit message that describes the goal (delay resolution to allow for interacting with "lazily populated" Maven artifacts from reactor for better integration with eg Felix) and the most important part of the implementation (do not fail preliminary TP build -used for build order- is some requirements are missing most likely because of an artifact not yet available and let build continue further, and fail later if necessary + do not consider pom dependencies in extra p2-based build order computation) ?

[laeubi]

I'll combine this into one commit and check the last TODO if I will do it now or later...

[laeubi]

Everything is one commit now.

[mickaelistria]

Thanks! Awesome change!
Please consider adding a note to the release notes about the capability to interact with other non-Tycho modules, that's a big big win to advertise ASAP!