Support Maven option --also-make-dependents, and --resume-from for project dependency resolution #577
Conversation
|
That's a great step forward. I would personally not see any issue with merging such iteration as long as it doesn't cause any regression. As the tycho-build extension is new, it's probably very safe to start using it here. |
I'm just calling code of P2 directly from maven as opposed to Tycho firing up an OSGi framework. This would not work so well here as we are at a very early phase, and even classloaders seem separated compared to later maven stages. So it is not really something one can "split off". |
Yes actually if not enabled code will never be called from there... and if enabled the tycho-code should never get aware of the extension code. |
…ph.GraphBuilder for project dependency resolution Add a basic GraphBuilder prototype Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
laeubi
force-pushed
the
551_graphbuilder_prototype
branch
from
03820f8
to
c3c191e
Compare
This is a basic prototype for #48 and #551 and also a showcase that Tycho could use P2 without the need of running it inside an OSGi-Framework (FYI @merks).
With this change (and enabling the tycho-build extension) the test cases from #564 succeed.
As there where some discussion why we don't "just fix this after such a long time", I'd like to give some insights about the efforts put into this prototype up to now (and its not complete but should work for common cases):
Beside the discussions and analysis in #48 with the useful hint/example code in #551 (thanks @sratz) and the provided test-cases in #564 (thanks @joeshannon) the following changes and refactoring where a perquisite:
To make this sustainable in the future the following changes in external projects where triggered and PRs provided:
Altogether I approximately spend 20 hrs of development time with coding, writing issues, reviewing, analysis and test.
And as mentioned this is a prototype and it is not complete, there is more work to do to make this complete and more useful (e.g. at the moment project dependencies are resolved twice once for graph building and once in the regular build).
Lust but not least I think we can integrate this at the current state in Tycho if there are no concern ( @mickaelistria @akurtakov ).
If this is crucial to someones business/workflow and likes to push the development forward in that area a sponsoring would allow me to assign more time-slots on these particular issue. Of course one can always contact me directly or contribute upon this initial prototype.