Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for "Asynchronous Verticle start and stop" unclear #2267

Closed
lonerzzz opened this issue Jan 9, 2018 · 2 comments
Closed

Documentation for "Asynchronous Verticle start and stop" unclear #2267

lonerzzz opened this issue Jan 9, 2018 · 2 comments
Milestone

Comments

@lonerzzz
Copy link

lonerzzz commented Jan 9, 2018

The documentation for the "Asynchronous Verticle start and stop" section in the core documentation does not clearly explain what is necessary to make the verticle deloyment work asynchronously making initial use of vertx more frustrating than need be, especially because it uses verticle deployment in the example making it self referencing.

I would suggest adding some vertx.executeBlocking() code to the start method in the example code and referencing the "Running blocking code" section to show how it is done to make it clearer to first time users.

@vietj
Copy link
Member

vietj commented Jan 10, 2018

I think we can use just an asynchronous timer instead that would be more clear

@vietj vietj added this to the 3.5.1 milestone Jan 30, 2018
@vietj
Copy link
Member

vietj commented Jan 31, 2018

I've a patch with an HTTP server instead of children verticles

@vietj vietj closed this as completed in 9c05433 Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants