Starter refactoring step 2 : start stop list commands #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mechanism for commands Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
…r is deleted) A few improvements and utilities methods Implement the run command and version commands Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
…loyer class (loaded from the created class loader). This class loader implement the -cp support and will be used for the redeploy. Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Set print stream for commands Improve Command model Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Works only on linux / mac for now. Need more testing. Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
…Dfastbuild=true) Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Also add tests Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
It was too tricky to manage the conflicts between -ha trigging a bare instance and an instance deployment. So manage it internally. Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
- Configuration - Enabling metrics from command line - Robustness of start / stop / list commands Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
* move public interface to the `io/vertx/core/spi/cli` package * move the implementation to `io/vertx/core/impl/cli` (as well as `io/vertx/core/impl/cli/commands` and `io/vertx/core/impl/cli/converters`) Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
it's not something used to develop a command but a launcher. Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
cescoffier
changed the title
|
perhaps you should wait PR1 is valid :-) |
|
It's in the description, so yes, it needs to wait until the PR1 is merged before merging that one. Changes made in the first PR will be reflected here. |
|
The CLI has been refactored, this PR is invalid. |
cescoffier
deleted the
starter-refactoring-step2-start-stop-list-commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the start stop and list commands.
These commands let you start vert.x application in background and control them. Commands works on Linux, Mac and Windows.
This PR is based on the #1110 PR.