WorkerExecutor must order tasks on the current Context and not on its… #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
worker-exec-ordering
branch
from
919a299
to
088ab95
Compare
This was referenced Mar 9, 2017
Merged
tsegismont
approved these changes
Mar 10, 2017
| @@ -26,12 +26,12 @@ | |||
| */ | |||
| class WorkerPool { | |||
|
|
|||
| private final OrderedExecutorFactory orderedFact; | |||
| // private final OrderedExecutorFactory orderedFact; | |||
There was a problem hiding this comment.
Can you remove this commented code?
| private final ExecutorService pool; | ||
| private final PoolMetrics metrics; | ||
|
|
||
| WorkerPool(ExecutorService pool, PoolMetrics metrics) { | ||
| this.orderedFact = new OrderedExecutorFactory(pool); | ||
| // this.orderedFact = new OrderedExecutorFactory(pool); |
There was a problem hiding this comment.
Can you remove this commented code?
| return orderedFact.getExecutor(); | ||
| } | ||
| // Executor createOrderedExecutor() { | ||
| // return orderedFact.getExecutor(); |
There was a problem hiding this comment.
Can you remove this commented code?
vietj
force-pushed
the
worker-exec-ordering
branch
from
088ab95
to
4b32d2b
Compare
This was referenced Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…elf - fixes #1867