Log target address when more than maxBufferedMessages buffered in consumer #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
reviewed
Mar 19, 2017
| @@ -177,7 +177,7 @@ public void handle(Message<T> message) { | |||
| if (discardHandler != null) { | |||
vietj
reviewed
Mar 19, 2017
| @@ -177,7 +177,7 @@ public void handle(Message<T> message) { | |||
| if (discardHandler != null) { | |||
| discardHandler.handle(message); | |||
| } else { | |||
| log.warn("Discarding message as more than " + maxBufferedMessages + " buffered in paused consumer"); | |||
| log.warn("Discarding message as more than " + maxBufferedMessages + " buffered in paused consumer (address {0})", address); | |||
There was a problem hiding this comment.
we should not use message interpolation as this is not portable
There was a problem hiding this comment.
@vietj ok, i do it like at line 65 in same file
…consumer Signed-off-by: jzajic <jan.zajic@corpus.cz>
jan-zajic
force-pushed
the
feature/discardLogging
branch
from
6cda414
to
ae241fc
Compare
|
@vietj, fixed according to your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only "warning" is very important message about data being lost. We need to known which endpoint failing to be able to fix backpressure in code ..
Signed-off-by: jzajic jan.zajic@corpus.cz