Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timers should be cancellable until they are fired - fixes #1899 #1900

Merged
merged 2 commits into from
Mar 27, 2017
Merged

Timers should be cancellable until they are fired - fixes #1899 #1900

merged 2 commits into from
Mar 27, 2017

Conversation

vietj
Copy link
Member

@vietj vietj commented Mar 27, 2017

@pmlopes @tsegismont please review

@vietj vietj mentioned this pull request Mar 27, 2017
Closed
cescoffier
cescoffier reviewed Mar 27, 2017
View reviewed changes
Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except 2 main classes that should probably be removed.

src/main/java/io/vertx/core/Main.java Outdated
@@ -0,0 +1,120 @@
package io.vertx.core;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed no ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg yes :-)

src/main/java/io/vertx/core/Main2.java Outdated
@@ -0,0 +1,47 @@
package io.vertx.core;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg yes :-)

@vietj vietj merged commit 4855ffb into master Mar 27, 2017
@vietj vietj removed the to review label Mar 27, 2017
@vietj vietj deleted the timers-should-be-cancellable-until-they-are-fired branch November 30, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vietj @cescoffier