Fix debug step-timeout-print for 32-bit platforms #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
__TIMESIZE seems to be glibc specific. Since these are always timeouts in seconds, I would suggest LOG_ARG("timeoutP: %d", (int)*timeoutP); |
core/liblwm2m.c
Outdated
| @@ -378,7 +378,8 @@ int lwm2m_step(lwm2m_context_t * contextP, | |||
| { | |||
| time_t tv_sec; | |||
|
|
|||
| LOG_ARG("timeoutP: %" PRId64, *timeoutP); | |||
| LOG_ARG("timeoutP: %d", *timeoutP); | |||
There was a problem hiding this comment.
Needs a type cast to int. (int)*timeoutP
|
Changed it now. I was concerned there may be an issue on Windows, but I cannot test except with compiler explorer (https://godbolt.org). |
Current debug prints of timeout between lwm2m steps assume time_t to be 64-bit. However, on MIPS and ARM this is not always given. This fix print the timeout number independently of the target architecture. Signed-off-by: Marc Lasch <marc.lasch@husqvarnagroup.com>
sbertin-telular
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current debug prints of timeout between lwm2m steps assume time_t to be
64-bit. However, on MIPS and ARM this is not always given. This fix will decide
at build time whether a 32-bit or 64-bit print format is needed.
This was tested on:
Signed-off-by: Marc Lasch marc.lasch@husqvarnagroup.com