Add more integration tests #611
Conversation
qleisan
force-pushed
the
integrationtests210525
branch
from
fdf23a2
to
37b77e3
Compare
|
|
||
|
|
||
| @pytest.mark.slow | ||
| #@pytest.mark.client_args("-t 60") |
There was a problem hiding this comment.
Why is this deselected, can it be removed?
There was a problem hiding this comment.
The entire testcase needs to be removed due to #607
tests/integration/conftest.py
Outdated
| @@ -46,6 +48,13 @@ def waitfortext(self,txt): | |||
| return False | |||
| return True | |||
|
|
|||
| def waitfortime(self, timedelay): | |||
| '''Wait for time and return output since last command''' | |||
There was a problem hiding this comment.
Single quotes slipped in here.
| text = lwm2mserver.waitfortime(20) # wait for max "pmax" | ||
| # Pass-Criteria A | ||
| assert text.count("Notify from client #0 /3/0/7") > 0 | ||
| assert text.count("Notify from client #0 /3/0/8") > 0 |
There was a problem hiding this comment.
Would it be feasible to check here also the values of Power Source Voltage (7) and Power Source Current (8)? Would be nice to check if the notification messages actually contain the observed values.
There was a problem hiding this comment.
Also add upper bound for check for number of notifications (during 20s)
| # one update is sent immediately, expect implementation | ||
| # to send update at lifetime/2 intervals | ||
| # this does not seem to be the case for 120s (more frequent) | ||
| assert text.count("Client #0 updated.") >= 2 |
There was a problem hiding this comment.
Why not test for exactly two updates during the lifetime? This however interferes with #613 when testing against 120s.
There was a problem hiding this comment.
TC removed. (The exact number of updates is implementation dependent)
qleisan
force-pushed
the
integrationtests210525
branch
from
37b77e3
to
76864e6
Compare
qleisan
force-pushed
the
integrationtests210525
branch
from
76864e6
to
cc66510
Compare
Add int-102, int-105, int-301, int-302
qleisan
force-pushed
the
integrationtests210525
branch
from
cc66510
to
c476927
Compare
Add int-102, int-105, int-107, int-301, int-302