Fail build on warning #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettichschnidi
force-pushed
the
gardena/rs/fix-warnings-2023-03-24
branch
3 times, most recently
from
b2a22e0
to
850bb27
Compare
Turn the -Wdiscarded-qualifiers into an error and fix the existing issues.
Fix and enforce absence of such issues.
Fix and enforce absence of such issues.
Fix and enforce absence of such issues.
Fix and enforce absence of such issues.
rettichschnidi
force-pushed
the
gardena/rs/fix-warnings-2023-03-24
branch
from
850bb27
to
0b639cd
Compare
No longer rely on unportable formatting strings.
Silence the existing, benign looking code, but ensure we get a warning for new code with such issues.
-Wunused-parameter yields the majority of the warnings. Ignoring it (for now) makes other, more relevant warnings better visible.
2 out of 2 cases are false positives.
This is code not (directly) under our control.
Using difftime() might be more clean, but uses doubles instead of integers.
Turn (almost) all warnings into errors to ensure no new warnings enter the code base. -Wcast-align is not an error because fixing the findings requires a bit more work than what I am willing to do right now and the tinydtls yields some findings.
Adapting changed lines: ``` git clang-format-14 --style=file master ```
rettichschnidi
force-pushed
the
gardena/rs/fix-warnings-2023-03-24
branch
from
0b639cd
to
e89761b
Compare
mlasch
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix or work around warnings in existing code base. Enforce warning free build in CI.
Probably best reviewed commit-by-commit, due to the reformatting required by clang-format.