Fix #83 : Enable vuejs support with vue-language-server #210
Conversation
|
I need to fill a lot of CQs. If I understand, I should do the following CQs. One for each files here:
One for the language server. I will upload node_modules folder. Am I right @mickaelistria ? |
|
Do you really need markdown, coffeescript as part of this change? If not, it would be better to separate them in a separate commit (I'm actually unsure about adding support for languages if there is no decent editor -aka language server- for them). Then, once we have the minimal set of dependencies, we can open CQs. |
|
In vue files (.vue) you can use different script languages. JavaScript is the primary one but you can choose TypeScript or CoffeeScript. So we need this file. About markdown grammar, the vue grammar declare a dependency on markdown grammar. More over, we can use markdown documentation into typescript code. So I think it's a good idea to add the markdown grammar. I will fill all CQs in few days (Hopefully tomorrow). I am actually in a train with a bad network connection. |
Ok. However if those scripts are "inlined", I don't think we need to declare content-types and associations. |
|
I also need to add some tests for the new language server. |
I will try with and without content type declaration. If it works without, I will clean plugin.xml |
|
I removed content-type for markdown and coffeescript. I also change the node dependency management to comply with your previous work. I will fill CQs in few minutes. |
|
About files from vscode repository. Should we create another CQ? I saw a CQ for subparts of vscode 1.37.1. |
…age-server Signed-off-by: Gautier de Saint Martin Lacaze <gautier.desaintmartinlacaze@gmail.com>
|
Other question about tweaking the Jenkinsfile. I'm not familiar with this. Should we increase memory with MAVEN_OPTS environment variable? |
Yes, the subparts only include the language servers. You'll need a separate on for the TextMate and language-configuration files.
Yes, I think it's the best approach. |
|
@jabby Is there anything blocking progress on this topic? |
|
Yes there is a problem with the following CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20748 I also need to create another CQ for part of vscode (some of textmate grammar) |
|
Ok, so it's "only" IP and there is no remaining technical challenge? |
|
I was just about to ask how I would go about adding Vuejs support! If there's anything I can do to help here I would be very interested. |
|
Hi @davydnorris It's a problem for us but I'm not sure it's a problem for vue-language-server which is under MIT License. I just created 2 issues about the license of stylint: |
|
Hey @jabby - have you had any luck with this at all? |
|
Hi all, Happy Western and Eastern NY! Any progress on this blockage at all? |
|
Hi all, I received notification from one of the blocking projects that their end has now been resolved - does this mean we are closer to being able to merge this pull request? It would be awesome to have Vue.js support - really like this plug-in!! |
Yes, probably, Please consider updating the PR to use latest version of dependencies, which should then use the fixed libraries. If this works and doesn't cause regression, we can trigger a further license/IP audit and if result is positive, we can merge. |
|
@jabby - could be good news???! This is your pull request - any chance you can update as above? |
|
We're stuck from IP perspective. I suggest this work should happen in a separate project, made available via Eclipse Marketplace (and associated with .vue files). |
Signed-off-by: Gautier de Saint Martin Lacaze gautier.desaintmartinlacaze@gmail.com