Fix github credencials (pass 2) #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrubezhny
force-pushed
the
fixGitHubCredentials-2
branch
from
3f3f83a
to
603ab44
Compare
|
Log says |
Github project credentials are to be used in `wget` action when accessing `https://raw.githubusercontent.com` in order to minimize restriction limits Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
force-pushed
the
fixGitHubCredentials-2
branch
from
603ab44
to
ce08119
Compare
Imho, it's OK and suits our needs - we don't want passwords/tokens to be visible in the log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github project credentials are to be used in
wgetaction when accessinghttps://raw.githubusercontent.comin order to minimize restriction limitsSigned-off-by: Victor Rubezhny vrubezhny@redhat.com