-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword arguments to blavFitIndices #43
Comments
Thanks, this sounds like a good addition. I believe that blavFitIndices() is calling fitMeasures() to obtain loo and waic, so it will probably take modification of at least two functions to do this. Any initial stab you take would be welcome, and I can clean up any parts of it that are confusing. PS I had to resist saying "This is a premium addition that can be purchased for 500 robux" :) |
Hey @ecmerkle, It looks like the situation is a bit more difficult than I anticipated. Moment matching is only available when applying
For reference, this is what lines around 576 look like:
I think |
Thanks for looking at it, and here is what I think is happening. In the big Stan file, I post-process a number of parameters in generated quantities, and then I only save the post-processed versions (using the
fit <- bsem(model, data, other_arguments, mcmcextra = list(monitor = c("Lambda_y_free", "more_pars")) Then, hopefully the moment matching would work on |
That works! Unfortunately, moment matching is not going to save my model, but I can add changes. It looks like Does that work for you? |
I'd glad it worked, even if it didn't help you! About the extra argument: I am trying to keep extra settings like this in Something could be done similarly here, where On the other hand, maybe the current functionality is enough since we can supply extra parameters to |
I think it would make sense to add I won't stop you if you want to make the changes, but I should be able to get up PR this weekend. Up to you! |
I won't get to it by the weekend, so will build off of anything you send! |
Hey Ed, I'm curious about this line. Why is the Line 906 in c58e805
|
I think it is because of the way that |
Hi there,
Thank you for this incredible software. When I run
blavFitIndices
on one of my models I get the warning:Warning: Some Pareto k diagnostic values are too high. See help('pareto-k-diagnostic') for details.
I was able to see that there is a single k value that is 0.7, which I believe is a good candidate for moment matching. Instead of solving this issue post hoc, I would like to add a
...
argument toblavFitIndices
. The...
argument would pass through to loo, waic, etc. If this works for you, I could start on a PR right away.Thanks again,
Matt
The text was updated successfully, but these errors were encountered: