Renamed 'grib_errors' parameter to 'errors' to match open_file() signature #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
===========================================
- Coverage 95.65% 53.93% -41.73%
===========================================
Files 26 26
Lines 2073 2073
Branches 238 231 -7
===========================================
- Hits 1983 1118 -865
- Misses 59 937 +878
+ Partials 31 18 -13
☔ View full report in Codecov by Sentry. |
… python-eccodes not available for it
|
This is a really nice PR, @Metamess, I'm just trying to sort out the CI before merging. |
iainrussell
approved these changes
Aug 18, 2023
|
Thank you very much for this PR - you also mentioned that the test environment needed to be updated and you were right, it did just in order for this to work! That was because it required a newer ecCodes, which in turn had some new requirements, and was not supported by Python 3.7. |
|
Thanks a lot for all the additional work Iain! Glad I could be of help 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #348
Fixes a bug where providing
"grib_errors"as key in backend_kwargs is required by some function (open_variable_datasets()) but causes a TypeError due to not being a recognized parameter in others (CfGribBackend.open_dataset()).Also fixes a test (
test_40_xarray_store.py::test_open_dataset_corrupted()) to specifically expect the type of Error associated with the expected issue, which was masking the TypeError.Additionally, also adds the following line to
test_40_xarray_store.py::test_open_dataset():xarray_store.open_dataset(TEST_DATA, backend_kwargs={"errors": "raise"})This tests that calling
open_dataset()with a known-good GRIB file and"errors": "raise"does not, in fact, raise an Error.