Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace distutils.version #318

Merged
merged 6 commits into from Nov 1, 2022
Merged

Replace distutils.version #318

merged 6 commits into from Nov 1, 2022

Conversation

headtr1ck
Copy link
Contributor

@headtr1ck headtr1ck commented Oct 23, 2022

This PR replaces distutils.version by packaging.version to silence the DeprecationWarning in the xarray plugin.

Closes #312

Also, I have added the new description and url attributes (someone might want to check these).

@FussyDuck
Copy link

FussyDuck commented Oct 23, 2022

CLA assistant check
All committers have signed the CLA.

@iainrussell
Copy link
Member

Many thanks @headtr1ck! I've allowed the tests to run, and as you can see there are some errors, which maybe you didn't get on your system.

@headtr1ck
Copy link
Contributor Author

Can you try again? I think I fixed all the problems.

@headtr1ck
Copy link
Contributor Author

this time with isort...

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Base: 95.49% // Head: 95.49% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b8c0904) compared to base (8578f10).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          26       26           
  Lines        2018     2020    +2     
  Branches      233      233           
=======================================
+ Hits         1927     1929    +2     
  Misses         61       61           
  Partials       30       30           
Impacted Files Coverage Δ
cfgrib/xarray_plugin.py 88.40% <80.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iainrussell iainrussell merged commit a317a88 into ecmwf:master Nov 1, 2022
@iainrussell
Copy link
Member

Thanks @headtr1ck, this was a nice little pull request, and you even updated the changelog - top marks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning for distutils Version classes
4 participants