Update package.json #508
Closed
Update package.json #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NODE_OPTIONS=--openssl-legacy-provider` produces error: "node: --openssl-legacy-provider is not allowed in NODE_OPTIONS" at least on node 16.X (Current LTS)
|
Hmm that's annoying. Master uses node 17 which doesn't work without this config 🤔 The new EthWallet package requires this config unfortunately. It's a shame to downgrade, are you able to upgrade to node 17 comfortably? |
|
Yes, that's fine no problem, perhaps just a notice in the README for others, I will submit a PR in the morning, getting late now |
|
Awesome thanks dude, I didn't think about people running without Docker. We'll keep this PR open for now for visibility. |
|
We do run within our own custom Docker, which makes upgrading to v17 easy, it's just our default to select an LTS normally without any other reason not to |
|
Ahah makes sense. I did also forget about the non-docker users though 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NODE_OPTIONS=--openssl-legacy-providerproduces error:
node: --openssl-legacy-provider is not allowed in NODE_OPTIONSat least on node 16.X (Current LTS)