Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keplr Suggest Chain for unsupported chains #82

Closed
tombeynon opened this issue Mar 7, 2022 · 7 comments
Closed

Keplr Suggest Chain for unsupported chains #82

tombeynon opened this issue Mar 7, 2022 · 7 comments

Comments

@tombeynon
Copy link
Contributor

Keplr only supports a few chains out of the box. I get an error There is no chain info for cheqd-mainnet-1 for Cheqd for example. We need to use the Suggest Chain feature to hook this up. Info can come from Chain Registry, and cosmos.directory APIs.

Adding issue for my tracking but this will hold up #76 and others for now. @Galadrin I think we chatted about this too.

@pwnfoo
Copy link
Contributor

pwnfoo commented Mar 8, 2022

Not sure what issue you're referring to here. I was able to add cheqd to Keplr just fine when I started a local version of restake.

Just the denoms looked broken

EDIT: Just realised this was because I already had it added in Keplr

@jemrickrioux
Copy link
Contributor

#87 This is covered in my last commit but we will need to make some changes to networks.json @tombeynon

  • Base denom (Ex.: ATOM vs minimal denom: uatom)
  • coinGeckoId
  • coinType (To support other types than 118 that is currently hardcoded

@Sdpierret
Copy link

Sdpierret commented Mar 8, 2022

@pwnfoo if you already know Cheqd network in your Keplr, you dont see the issue.
on a fresh Keplr install, you will need to add the network, and the SuggestChain is mandatory

(I'm Galadrin, second Github account)

@tombeynon
Copy link
Contributor Author

Fantastic work 💥

Base denom we can get from chain registry
Coin gecko again in CR
Coin type we can just set in networks.json when we identify a network needs it.

Might separate your Suggest Chain work from #87 so we can merge it separately, would be great to get that in sooner

@jemrickrioux
Copy link
Contributor

@tombeynon #91 Here is the clean branch, I will need to add the 2 values from CR

@jemrickrioux
Copy link
Contributor

Fantastic work 💥

Base denom we can get from chain registry Coin gecko again in CR Coin type we can just set in networks.json when we identify a network needs it.

Might separate your Suggest Chain work from #87 so we can merge it separately, would be great to get that in sooner

These have been done in my new PR #91

@jemrickrioux
Copy link
Contributor

#123 - Merging as we speak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants