Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleCompiler会忽略先前processor的文件修改 #6

Closed
otakustay opened this issue Sep 26, 2013 · 6 comments
Closed

ModuleCompiler会忽略先前processor的文件修改 #6

otakustay opened this issue Sep 26, 2013 · 6 comments
Assignees
Labels

Comments

@otakustay
Copy link
Member

参见这行:https://github.com/ecomfe/edp-build/blob/master/lib/processor/module-compiler.js#L65

这里用的是rawData,我在ModuleCompiler前还有一个processor,将某些文件进行了些改动,自动添加一些代码,然后经过ModuleCompiler后这些代码就又消失了

这个当时是有什么考虑吗?

@leeight
Copy link
Member

leeight commented Sep 28, 2013

还是@errorrik 看看吧,我也不知道当时是怎么考虑的?

@ghost ghost assigned erik168 Sep 28, 2013
@errorrik
Copy link

原来的编译过程有这么个情况:对于模块main

  1. 先扫到它时把它编译了
  2. 后来扫到index.html,发现main需要combine,然后重新以combine模式编译

这时候就需要走rawData

@otakustay
Copy link
Member Author

那回归问题的本质,在Compiler处理以前对module做的自动化的修改,有什么办法保留下来呢?毕竟通过build脚本生成重复性代码对项目效率提升很有帮助,要去分析编译完的模块太困难了

@errorrik
Copy link

现在可以不走rawData了。自动扫瞄入口模块并合并这事已经取消了。现在想要让一个模块合并,需要在module.conf里面配

@ghost ghost assigned errorrik Oct 11, 2013
@otakustay
Copy link
Member Author

看来用data是可以的?你给改了呗,不熟悉整个代码我怕改漏了……

@errorrik
Copy link

就这一个地方而已...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants