Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

er@3.1.0-rc.2 与 mini-event@2.0.1 兼容问题 #169

Open
yibuyisheng opened this issue Mar 24, 2016 · 3 comments
Open

er@3.1.0-rc.2 与 mini-event@2.0.1 兼容问题 #169

yibuyisheng opened this issue Mar 24, 2016 · 3 comments

Comments

@yibuyisheng
Copy link
Member

目前发现的是在er@3.1.0-rc.2的Deferred.js里面使用了mini-event中EventTarget的enable静态方法,但是这个静态方法在mini-event@2.0.1中去掉了。

@otakustay
Copy link
Member

详细说明一下这个问题

er在package.json中声明的mini-event的版本是1.x,而去除enable方法是在2.x中进行的,如果严格遵守依赖版本限制,是不会出这事的

@yibuyisheng 聊了一下,具体原因是使用了emc,而emc依赖的是2.x,因此导致整个版本被提升了

这个问题的本质是我们的edp没能做同库多版本的管理和require.config#map的配置管理,这个问题不知道 @leeight 是不是有啥想法,或者其实已经支持了

为了解决这一问题,我会做几个临时方案:

  1. 先对Deferred进行修改,使其从EventTarget继承而非使用enable
  2. 调整er中的require,如果存在.default就使用,即支持interopRequireDefault功能
  3. 发布一版ES6编写的er,为4.x版本

@otakustay
Copy link
Member

请试用3.1.1

4.x版本暂时pending,后续根据yami库的进度考虑

@yibuyisheng
Copy link
Member Author

好的,感谢 @otakustay 大神!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants