Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/account addresses #256

Merged
merged 6 commits into from Jun 29, 2020
Merged

Feat/account addresses #256

merged 6 commits into from Jun 29, 2020

Conversation

Raullages
Copy link
Contributor

Copy link
Member

@leomp12 leomp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raullages gostei de ver que você lembrou do nome do evento 👍
Comentei umas coisinhas mas só minors agora (não envolve API nem feature).

@ecomplus/storefront-components/src/js/AccountAddresses.js Outdated Show resolved Hide resolved
@ecomplus/storefront-components/src/js/AccountAddresses.js Outdated Show resolved Hide resolved
@ecomplus/storefront-components/src/js/AccountAddresses.js Outdated Show resolved Hide resolved
Comment on lines 1 to 9
.account-addresses {
&__card {
margin-bottom: 1rem;
font-size: .9rem;

label {
width: 100%;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eita, aqui no SCSS a indentação foi pro saco 😛

Copy link
Member

@leomp12 leomp12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valeu @Raullages 👍

@leomp12 leomp12 merged commit a37811e into master Jun 29, 2020
@leomp12 leomp12 deleted the feat/account-addresses branch June 29, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants