Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert doesn't close file #4

Closed
flwyd opened this issue Apr 19, 2022 · 1 comment
Closed

convert doesn't close file #4

flwyd opened this issue Apr 19, 2022 · 1 comment

Comments

@flwyd
Copy link
Contributor

flwyd commented Apr 19, 2022

Rather than installing this as a gem, I ran an interactive irb session, required the file in lib, and called

log = ::PotaCsvToAdif::LogFile.new('my.csv')
log.convert

This resulted in an empty my.adi file until I exited the interpreter, which flushed the written data to disk and closed the output file.

convert should ensure the output file is closed, possibly by passing a block to File.open.
@ecopony
Copy link
Owner

ecopony commented May 29, 2022

Fixed with #5

@ecopony ecopony closed this as completed May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecopony @flwyd