-
Notifications
You must be signed in to change notification settings - Fork 7
Update action missing latest runs? #63
Comments
A few things at play here:
So we will pick up that Safari 15.0 run tomorrow I think (the gh-pages action runs Mon,Wed,Fri), but it's a reasonable criticism to note that we have a 36-48 hour lag on picking up a given run even if we were running the action every day of the week. Minimizing this delay would likely involve making build.sh pick up runs until 'today' (not 'yesterday') and then carefully aligning the action times so that the runs for that day have (probably) already happened and have already been ingested to https://github.com/ecosystem-Infra/wpt-results . Unfortunately that isn't work I have time for, but PRs are welcome :). |
While I know @stephenmcgruer has now manually triggered an update (especially for WPT), and Compat 2021 now shows STP 135, various people have questioned both that and the Browser-Specific-Failure (BSF) graph not being updated more readily. It's a shame that the action only runs a few times a week (and changing that to daily should be trivial!). AIUI, the big challenge here is the wpt.fyi API for queries such as the above (e.g., https://wpt.fyi/api/runs?&label=master&label=stable&product=chrome&product=firefox&product=safari&aligned=true&max-count=1&from=2021-10-27&to=2021-10-28) returns the latest test runs where the
Unfortunately, that's difficult as long as copyright is held by the authors and/or their employers and this isn't licensed under an open-source license (c.f. #58). 🙃 |
I'm noticing this issue today again because STP 136 was just released, but triggering all the updates manually still doesn't update the data due to the @stephenmcgruer do you recall why this was included in 2fe8143 in the first place? browser-specific-failures.js already uses aligned runs... Was it something like runs appearing out of order and wanting to leave a margin for that noise to settle? |
From what I recall, it was a conservative guard against failure due to no runs detected, especially due to the caching logic (which is likely irrelevant to the GitHub action but is relevant locally). I don't think there's anything fundamentally impossible about bringing the cut-off date closer, but we previously weren't interested in cutting-edge run results for compat2021 and so decided better safe than sorry ;) |
c.f. Ecosystem-Infra#63 There's very little reason not to do this on a daily basis; GitHub Actions certainly has the capacity to run this on a daily basis, and it provides more timely results. The only downside is it makes the graph data files bigger, but in reality these are still relatively small files (especially in comparison to other files which wpt.fyi loads).
c.f. #63 There's very little reason not to do this on a daily basis; GitHub Actions certainly has the capacity to run this on a daily basis, and it provides more timely results. The only downside is it makes the graph data files bigger, but in reality these are still relatively small files (especially in comparison to other files which wpt.fyi loads).
Thanks @stephenmcgruer! Sounds like there are issues we might run into, but we can give it a try to shorten the pipeline and see what happens. |
Closing in favor of web-platform-tests/results-analysis#65 ahead of archiving this repo. |
The "Update gh-pages" action last ran on 27 Oct 2021, 13:27 BST, and produced 4722ba4
However, the only seems to have picked up runs to 2021-10-25, and not any of the more recent runs on wpt.fyi, especially for stable where we had our first Safari 15 run in that intervening period: https://wpt.fyi/runs?label=master&label=stable&max-count=100&from=2021-10-21T00%3A00&product=chrome&product=firefox&product=safari&aligned
The text was updated successfully, but these errors were encountered: