Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Add local address and api address #9

Closed
wants to merge 1 commit into from

Conversation

sveldhuisen
Copy link

@sveldhuisen sveldhuisen commented Apr 9, 2022

Hi Eugen,

In the light of Open Source software, I thought it would be good to give something back to this project.

Winfoom's listeners are currently binding on all available addresses. This can be a security issue, as the proxy can be open to the entire network.

This is not a problem for normal proxy usage. However, when Winfoom is used to access a protected API on an IIS server, the rest of the world is not allowed to do so.

So I have enhanced Winfoom to make the socket listener configurable so that it can be made available only on localhost, for example.

I have also made the API address configurable, so that it can be shielded from the rest of the network as well.

I hope you appreciate my contribution. I'm not a Java guru myself, but I think the enhancement works fine.

@sveldhuisen
Copy link
Author

Hi Eugen,

I have made a 4.0.4-SNAPSHOT release in my local forked branch: test results are ok.

@ecovaci
Copy link
Owner

ecovaci commented Apr 13, 2022

Hello,

The proxy access control should be firewall's job. I don't think we should add this kind of restrictions since this functionality does not belong to a proxy façade. Sorry for your effort and thanks again for your interest in this project.

@sveldhuisen
Copy link
Author

sveldhuisen commented Apr 13, 2022

Hi Eugen,

Unfortunate that we won't agree. The proposed enhancement allows you to run Winfoom on a specific address. This is very useful if you would run it on a server with multiple addresses on different VLAN's. You can even run multiple instances of Winfoom on the same port, but on different IP addresses. Also do note that Winfoom supports HTTP mode so you can run it to get access to a regular II Web Server. It is not only about connection to a SOCK proxy.

I do hope you reconsider my pull request. Otherwise I'm forced to run a fork of this excellent piece of software.

@ecovaci ecovaci closed this Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants