Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEC boundaries: Copy values in guard cells #3900

Closed
roelof-groenewald opened this issue May 5, 2023 · 3 comments · Fixed by #4840 · May be fixed by #3842
Closed

PEC boundaries: Copy values in guard cells #3900

roelof-groenewald opened this issue May 5, 2023 · 3 comments · Fixed by #4840 · May be fixed by #3842
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: boundary PML, embedded boundaries, et al.

Comments

@roelof-groenewald
Copy link
Member

With PEC boundaries, charge and current density deposited in guard cells outside the domain (inside PEC boundaries) are either reflected back into the simulation domain or subtracted from internal cells (to represent image charge contributions). Currently, the values in guard cells at the corner of simulation boxes are not gathered during the SumBoundary call, which means that small amounts of density is lost in those overlapping regions.

[cc. @WeiqunZhang ]

@WeiqunZhang
Copy link
Member

The communication capability is there. It's currently used for PSATD. We need to enable it for PEC boundaries too.

https://github.com/ECP-WarpX/WarpX/blob/development/Source/Parallelization/WarpXSumGuardCells.H

@ax3l ax3l added bug Something isn't working bug: affects latest release Bug also exists in latest release version component: boundary PML, embedded boundaries, et al. labels May 8, 2023
@WeiqunZhang
Copy link
Member

And more seriously the densities on nodes are not consistent between boxes. That's probably why the solver fails.

@ax3l
Copy link
Member

ax3l commented Apr 8, 2024

X-ref: #4833 might be related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: affects latest release Bug also exists in latest release version bug Something isn't working component: boundary PML, embedded boundaries, et al.
Projects
None yet
3 participants