Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to 3D is broken? #34

Open
naeemmrz opened this issue Feb 2, 2022 · 2 comments
Open

Convert to 3D is broken? #34

naeemmrz opened this issue Feb 2, 2022 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@naeemmrz
Copy link

naeemmrz commented Feb 2, 2022

Hello,

I'm trying to generate the PaDEL 3D descriptors for a small dataset; I've set the as the code snip below and prepared an XML file the 3D descriptors set to True and left the rest as False however the out files are all empty values. Is there something wrong with my approach or are the 3D descriptors broken?
PS: I'm calculating it from smiles supplied as a smi file, the 2D descriptors work fine with the same input.
padeldescriptor(mol_dir='temp.smi', d_file='PaDEL_3D.csv', descriptortypes= '3D.xml', detectaromaticity=True, standardizenitro=True, convert3d=True, d_2d=False, d_3d=True, standardizetautomers=True, threads=2, removesalt=True, log=False, retainorder=True, fingerprints=False)

@shenglisa
Copy link

excuseme, have you solved this problem?

@tjkessler
Copy link
Member

Hi @naeemmrz,

Not sure what's going on here... the arguments for generating 3D descriptors and converting to 3D should be passed via the command line to PaDEL, with:

if headless:
    command = 'java -Djava.awt.headless=true -jar {}'.format(_PADEL_PATH)
else:
    command = 'java -jar {}'.format(_PADEL_PATH)
command += ' -maxruntime {}'.format(maxruntime)
command += ' -waitingjobs {}'.format(waitingjobs)
command += ' -threads {}'.format(threads)
command += ' -maxcpdperfile {}'.format(maxcpdperfile)
"""
...
"""
if d_3d is True:
    command += ' -3d'
"""
...
"""
if convert3d is True:
    command += ' -convert3d'
"""
...
"""
p = Popen(command.split(), stdout=PIPE, stderr=PIPE)

Not sure if there are any strange interactions between arguments - I'll keep this issue open, maybe someone with more familiarity with the PaDEL-Descriptor source code can chime in.

Best,
Travis

@tjkessler tjkessler added bug Something isn't working help wanted Extra attention is needed labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants