Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Question: who should add the "entities" to the scene? #55

Closed
endel opened this issue Aug 21, 2019 · 7 comments
Closed

Question: who should add the "entities" to the scene? #55

endel opened this issue Aug 21, 2019 · 7 comments
Projects

Comments

@endel
Copy link
Contributor

endel commented Aug 21, 2019

Hi @fernandojsg, really nice API you got there! Thanks for sharing this.

Following ECS and other design patterns, I'm wondering who's the responsibility of adding an entity to the scene, into the right container? A "controller"? 👀

Speaking of THREE.js, an Object3D should be added (.add()) somewhere. Maybe in the root scene, maybe as a child in another object.

Do you have an opinion about this?
Thanks!

@endel
Copy link
Contributor Author

endel commented Aug 21, 2019

For example, let's say an EnemySpawnerSystem decides to spawn a new enemy / entity. How should this system know where to add it to the scene? 👀

@fernandojsg fernandojsg added this to Backlog in ECSY Core Aug 23, 2019
@fernandojsg
Copy link
Member

Hi @endel ! thanks for your interest on the project, happy that you like it so far :)
We would like to use github for issues about the core library itself instead of usage questions and so, similar how they do on other libraries as three.js and moving these kind of discussions to a forum, in this case this one: https://discourse.mozilla.org/c/mixed-reality/ecsy
So it could be also a useful source of info for people using the lib.
Do you mind starting a thread there and I'll go ahead and close this one? :)
Thanks again!

@endel
Copy link
Contributor Author

endel commented Aug 27, 2019

Alright, I was going to register on Mozilla discourse but this error is appearing on the console whenever I click to login/register 😭 Screenshot 2019-08-27 at 16 50 42

@fernandojsg
Copy link
Member

Ouch, I'll report that, could you give it a try on firefox? it worked for me there :)

@fernandojsg
Copy link
Member

@endel I just got confirmation that it was fixed already, you can try on chrome again :)

@endel
Copy link
Contributor Author

endel commented Aug 28, 2019

thanks, it works, posted here https://discourse.mozilla.org/t/who-should-add-the-entities-to-the-scene/44393

❤️

@endel endel closed this as completed Aug 28, 2019
ECSY Core automation moved this from Backlog to Done Aug 28, 2019
@fernandojsg
Copy link
Member

Awesome, thanks! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
ECSY Core
  
Done
Development

No branches or pull requests

2 participants