Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'connected' event triggers before the SerialPort is opened #48

Open
fcovas opened this issue May 2, 2014 · 0 comments
Open

'connected' event triggers before the SerialPort is opened #48

fcovas opened this issue May 2, 2014 · 0 comments

Comments

@fcovas
Copy link

fcovas commented May 2, 2014

If I run the examples/basic.js the application crashes because the serial port is not opened on the 'connected' event. Shouldn't the 'connected' event only be emitted after the SerialPort 'open' event?

Here https://github.com/ecto/duino/blob/master/lib/board.js#L28, instead of:

self.emit('connected');

do this:

self.serial.on('open', function(){
    self.emit('connected');
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant