Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

Change get_podcast_downloader return type #22

Open
ed-cooper opened this issue Jan 5, 2020 · 2 comments
Open

Change get_podcast_downloader return type #22

ed-cooper opened this issue Jan 5, 2020 · 2 comments
Labels
ergonomics Related to the ease of maintaining the code

Comments

@ed-cooper
Copy link
Owner

This return type is the only thing preventing the entire PodcastProvider interface being entirely independent of the web.

The return type will need to support asynchronous downloading and contain the total download size (as given by int(http_download_response.headers['Content-Length'])).

This will probably require the creation of a new class for the return type.
@ed-cooper ed-cooper added ergonomics Related to the ease of maintaining the code help wanted Extra attention is needed labels Jan 5, 2020
@ed-cooper
Copy link
Owner Author

The current return type (requests.Response) also does not guarantee that response streaming is even supported, giving more motivation to change it

@ed-cooper
Copy link
Owner Author

Looks like the stream type will have to be an iterator

@ed-cooper ed-cooper removed the help wanted Extra attention is needed label May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
ergonomics Related to the ease of maintaining the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ed-cooper