Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID space is not compacted #2

Closed
edawson opened this issue Oct 3, 2016 · 1 comment
Closed

ID space is not compacted #2

edawson opened this issue Oct 3, 2016 · 1 comment

Comments

@edawson
Copy link
Owner

edawson commented Oct 3, 2016

lasso uses the IDs as a map(basepair : node) in the graph. This unfortunately means that our ID space across multiple contigs quickly grows, and that there are collisions in the GFA output if we have multiple variant contigs (though we could construct each contig graph individually and then join them with a vg ids -j).

We should ideally maintain our map outside of ID space and then increment IDs by one every time a new node is added. This is in line with what VG does.

@edawson
Copy link
Owner Author

edawson commented Nov 24, 2016

Fixed.

@edawson edawson closed this as completed Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant